fix(typst): prevent breaking inside definition items #13978
Merged
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that terms and their descriptions remain together by setting the block to be non-breakable.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mcanouil
changed the title
Verifies that definition list terms and descriptions stay on the same page and that descriptions are indented from terms. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
I added a test using ensurePdfTextPositions. Without the fix, it reports |
mcanouil
commented
Jan 30, 2026
gordonwoodhull
approved these changes
Jan 30, 2026
cderv
approved these changes
Feb 2, 2026
Collaborator
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
Thank you!
I see this is added in definitions.typ and concerns Definition block which is a Pandoc blocks initially.
Would that be worth also making a PR in Pandoc for this fix to be upstream too ?
Collaborator
Author
|
The terms rule is already different from Pandoc, should it be part of the PR? Edit: in fact the rule is incompatible with how Pandoc writes terms definition. #show terms: it => {
it
.children
.map(child => block(breakable: false)[
#text(weight: "bold")[#child.term]
#block(inset: (left: 1.5em, top: -0.4em))[#child.description]
])
.join()
}Question is: should we update upstream and use the above rule instead of the two? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure terms and their descriptions remain together by preventing breaks within definition items.
The rule needs to be separate from the content rule, because here we play on the implicit block generated by Typst.
As this is a visual change, there are no tests, but I believe non breaking term/definition is a sensible default.